aws-deadline / deadline-cloud-worker-agent

The AWS Deadline Cloud worker agent can be used to run a worker in an AWS Deadline Cloud fleet.
Apache License 2.0
15 stars 21 forks source link

test: add worker log writing to local disk test #478

Closed YutongLi291 closed 3 days ago

YutongLi291 commented 1 week ago

Requires https://github.com/aws-deadline/deadline-cloud-worker-agent/pull/477 to be merged first due to conftest additions.

What was the problem/requirement? (What/Why)

When jobs are ran with worker agent, the worker writes the session log, worker log, and worker bootstrap logs to the disk on the worker instance (with the default options if the worker logs aren't manually turned off).

We should verify that these logs are written, accessible by the worker user, and not accessible by the job user and prevent regressions in the future.

What was the solution? (How)

Add a test that verifies that worker will write these files to disk, and that they're accessible by the worker user, and not accessible by the job user.

What is the impact of this change?

Better testing to verify that worker and session logs are written to disk by the worker

How was this change tested?

# Linux
source .e2e_linux_infra.sh
hatch run e2e-test

# Windows
source .e2e_windows_infra.sh
hatch run e2e-test

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud