Depends on release of aws-deadline/deadline-cloud-test-fixtures#164
What was the problem/requirement? (What/Why)
The worker agent end-to-end tests had overridden the worker_config fixture from deadline-cloud-test-fixtures to work around bugs and enhance its functionality. This bug has been fixed upstream (see aws-deadline/deadline-cloud-test-fixtures#164)
The worker agent end-to-end tests had used a combination of:
These are redundant. We should not need to use both of the above for each test case.
What was the solution? (How)
Modify the worker_config fixture override to inherit the value from deadline-cloud-test-fixture but modify only the parts necessary
Modify the operating_system fixture to take its value from the OPERATING_SYSTEM environment variable
What is the impact of this change?
There is less duplication of the worker_config fixture from the upstream deadline-cloud-test-fixtures package and we do not have to maintain synchronization of their logic
Tests are simpler to write and do not need a combination of pytest parametrization and conditional skipping. Test authors only need to use test skipping
How was this change tested?
Setup the environment with hatch env create
Installed the mainline version of deadline-cloud-test-fixtures (includes aws-deadline/deadline-cloud-test-fixtures#164) into the hatch env:
Depends on release of aws-deadline/deadline-cloud-test-fixtures#164
What was the problem/requirement? (What/Why)
The worker agent end-to-end tests had overridden the
worker_config
fixture fromdeadline-cloud-test-fixtures
to work around bugs and enhance its functionality. This bug has been fixed upstream (see aws-deadline/deadline-cloud-test-fixtures#164)The worker agent end-to-end tests had used a combination of:
These are redundant. We should not need to use both of the above for each test case.
What was the solution? (How)
worker_config
fixture override to inherit the value fromdeadline-cloud-test-fixture
but modify only the parts necessaryoperating_system
fixture to take its value from theOPERATING_SYSTEM
environment variableWhat is the impact of this change?
worker_config
fixture from the upstreamdeadline-cloud-test-fixtures
package and we do not have to maintain synchronization of their logicHow was this change tested?
hatch env create
Installed the
mainline
version ofdeadline-cloud-test-fixtures
(includes aws-deadline/deadline-cloud-test-fixtures#164) into the hatch env:Was this change documented?
Yes, updated
test/e2e/README.md
with updated documentation for writing os-specific tests.Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.