aws-deadline / deadline-cloud

Multi-purpose library and command line tool that implements functionality to support applications using AWS Deadline Cloud.
Apache License 2.0
25 stars 28 forks source link

feat: move job attachments time stamp to after download. Add a retry to ensure timestamp is updated #418

Closed leongdl closed 1 month ago

leongdl commented 2 months ago

What was the problem/requirement? (What/Why)

What was the solution? (How)

What is the impact of this change?

Updates

How was this change tested?

hatch build
hatch run fmt
hatch run lint
hatch run test
....
....
Required test coverage of 80.0% reached. Total coverage: 84.33%
================================================================================================ slowest 5 durations =================================================================================================
2.05s call     test/unit/deadline_job_attachments/test_upload.py::TestUpload::test_asset_management_no_outputs_large_number_of_inputs_already_uploaded[2023-03-03-100]
1.87s call     test/unit/deadline_job_attachments/test_upload.py::TestUpload::test_asset_management_many_inputs[2023-03-03-100]
1.67s call     test/unit/deadline_job_attachments/test_progress_tracker.py::TestProgressTracker::test_increment_race_condition
1.52s call     test/unit/deadline_job_attachments/test_upload.py::TestUpload::test_asset_management_no_outputs_large_number_of_inputs_already_uploaded[2023-03-03-200]
1.49s call     test/unit/deadline_job_attachments/test_upload.py::TestUpload::test_asset_management_many_inputs[2023-03-03-200]
============================================================================== 1326 passed, 46 skipped, 1 xfailed, 2 warnings in 18.64s ==============================================================================
hatch run integ:test
...
================================================================================================ slowest 5 durations =================================================================================================
10.14s setup    test/integ/deadline_job_attachments/test_job_attachments.py::test_upload_input_files_all_assets_in_cas[2023-03-03]
8.74s call     test/integ/deadline_job_attachments/test_job_attachments.py::test_sync_outputs_no_job_attachment_settings_in_job[2023-03-03]
7.18s setup    test/integ/deadline_job_attachments/test_job_attachments.py::test_sync_inputs_with_step_dependencies[2023-03-03]
5.43s teardown test/integ/deadline_job_attachments/test_job_attachments.py::test_download_outputs_windows_max_file_path_length_exception[2023-03-03]
4.48s call     test/integ/deadline_job_attachments/test_job_attachments.py::test_sync_inputs_with_step_dependencies[2023-03-03]
====================================================================================== 14 passed, 1 skipped in 66.15s (0:01:06) ======================================================================================

Was this change documented?

Not applicable, no APIs or customer behaviors are changed.

Is this a breaking change?

No - this change is only moving the code logic around.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud