aws-deadline / deadline-cloud

Multi-purpose library and command line tool that implements functionality to support applications using AWS Deadline Cloud.
Apache License 2.0
25 stars 28 forks source link

docs: enhance contributing guidelines #437

Closed ddneilson closed 1 month ago

ddneilson commented 1 month ago

What was the problem/requirement? (What/Why)

The contributing and developer guidelines in this repository assume a fairly high level of familiarity with this package's developers workflows and mostly serve as memory jogs for those developers. This makes it challenging for those who did not create the package to understand the development and contributing workflows.

What was the solution? (How)

Rework/refactor the CONTRIBUTING.md, DEVELOPMENT.md, GitHub issue templates, and pull request template with the goal of improving understandability to those not familiar with the code base, hatch-based workflows, GitHub pull request workflows, and our use of conventional commits. Also added a pytest marker to the job attachments cross-account tests just to make it easier to differentiate them from other integration tests.

What is the impact of this change?

The hope is that the development and contribution process should be much clearer for everyone.

How was this change tested?

N/A - docs. Though, I did make sure that the instructions for running the integration tests works.

Was this change documented?

It is documentation ;-)

Is this a breaking change?

Nope. No code.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud