Updates documentation for getting started with the simple build pipeline sample and adds missing defaults packer template.
Changes
added warnings regarding the region variable in packer templates as they default to us-west-2 and can cause errors.
Changed Packer commands to proper syntax in getting started docs
Changed the Note admonition in the Amazon Linux 2023 ARM based Amazon Machine Image section to a warning, as not heading that admonition would cause the command to fail.
Added defaults to the vpc_id and subnet_id variables in amazon-linux-2023-arm64.pkr.hcl, allowing Packer to default to the default VPC if no value is passed in.
Renamed the fully_qualified_domain_name reference inStep 5. Configure Simple Build Pipeline Variables to root_domain_name to align with name change in code.
Split Step 5. Configure Simple Build Pipeline Variables section into local.tf and variables.tf paragraphs to align with module structure.
User experience
Fixes faulty code and clarifies sections which are most likely to cause issues for users.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
Is this a breaking change?
No
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.
henrykie
commented
1 month ago
Issue number: #355
Summary
Updates documentation for getting started with the simple build pipeline sample and adds missing defaults packer template.
Changes
us-west-2and can cause errors.Noteadmonition in theAmazon Linux 2023 ARM based Amazon Machine Imagesection to a warning, as not heading that admonition would cause the command to fail.vpc_idandsubnet_idvariables inamazon-linux-2023-arm64.pkr.hcl, allowing Packer to default to the default VPC if no value is passed in.fully_qualified_domain_namereference inStep 5. Configure Simple Build Pipeline Variablestoroot_domain_nameto align with name change in code.Step 5. Configure Simple Build Pipeline Variablessection intolocal.tfandvariables.tfparagraphs to align with module structure.User experience
Fixes faulty code and clarifies sections which are most likely to cause issues for users.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
NoAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.