aws-greengrass / aws-greengrass-gdk-cli

The Greengrass Development Kit - Command Line Interface (GDK CLI) is a tool that helps you create Greengrass V2 components either using templates or community repositories.
https://docs.aws.amazon.com/greengrass/v2/developerguide/greengrass-development-kit-cli.html
Apache License 2.0
28 stars 18 forks source link

fix: remove pyinquirer dependency to work with python 3.10+ #246

Closed patrzhan closed 11 months ago

patrzhan commented 11 months ago

Issue #, if available:

Description of changes: Use python built-in input function to prompt for inputs instead of PyInquirer. To use the existing default value users should leave the input field blank.

Why is this change necessary: PyInquirer does not have a maintainer anymore (https://github.com/CITGuru/PyInquirer/issues/159) and does not work on python versions past 3.10 due to a deprecated import statement in one of PyInquirer's dependent packages. Since we cannot expect this project to be updated and we want to ensure that we support later and current releases of python we cannot use PyInquirer.

How was this change tested: Manually tested the changes.

Any additional information or context required to review the change: Unit tests don't exist (yet). They will be in a future PR. This is just a quick fix in the meantime to move away from this dependency.

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (019f0a0) 93.70% compared to head (56c0b0b) 94.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #246 +/- ## =============================================== + Coverage 93.70% 94.04% +0.33% =============================================== Files 47 47 Lines 1796 1796 =============================================== + Hits 1683 1689 +6 + Misses 113 107 -6 ``` | [Flag](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | Coverage Δ | | |---|---|---| | [integ](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `80.28% <0.00%> (-0.06%)` | :arrow_down: | | [uat](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `70.21% <0.00%> (-0.06%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `90.42% <100.00%> (+0.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | Coverage Δ | | |---|---|---| | [gdk/wizard/Prompter.py](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass#diff-Z2RrL3dpemFyZC9Qcm9tcHRlci5weQ==) | `28.86% <100.00%> (+4.12%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/246/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.