search

aws-greengrass / aws-greengrass-gdk-cli

The Greengrass Development Kit - Command Line Interface (GDK CLI) is a tool that helps you create Greengrass V2 components either using templates or community repositories.
https://docs.aws.amazon.com/greengrass/v2/developerguide/greengrass-development-kit-cli.html
Apache License 2.0
28 stars 18 forks source link

chore: update logging level for latest gtf release logs #276

Closed patrzhan closed 8 months ago

patrzhan commented 8 months ago

Issue #, if available:

Description of changes: Changes some debug logs for grabbing the latest GTF release from info level logging to debug. These statements will appear on any command as they are run when setting up the tool configuration and we shouldn't show them by default.

Why is this change necessary: Keep the cli tool output clean. We don't want to always display this information and especially not when a command unrelated to e2e testing is run.

How was this change tested: Manually tested and the logs show with the debug flag and not otherwise. No unit/integration testing required.

Any additional information or context required to review the change:

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (db8f54d) 97.87% compared to head (b7d587c) 97.92%.

Files Patch % Lines
gdk/common/config/TestConfiguration.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #276 +/- ## =============================================== + Coverage 97.87% 97.92% +0.05% =============================================== Files 49 49 Lines 1928 1927 -1 =============================================== Hits 1887 1887 + Misses 41 40 -1 ``` | [Flag](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | Coverage Δ | | |---|---|---| | [integ](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `81.00% <66.66%> (+0.04%)` | :arrow_up: | | [uat](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `71.76% <66.66%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aws-greengrass/aws-greengrass-gdk-cli/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass) | `93.87% <66.66%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-greengrass#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.