aws-greengrass / aws-greengrass-nucleus

The Greengrass nucleus component provides functionality for device side orchestration of deployments and lifecycle management for execution of Greengrass components and applications. This includes features such as starting, stopping, and monitoring execution of components and apps, interprocess communication server for communication between components, component installation and configuration management.
Apache License 2.0
109 stars 45 forks source link

fix: fail deployment if prepare bootstrap fails #1657

Open alter-mage opened 2 months ago

alter-mage commented 2 months ago

Issue #, if available:

Description of changes: Do not restart Nucleus if kernel update deployment fails while preparing bootstrap. Instead, fail the deployment and start up all the services currently configured.

Something which is a bit unknown is what should the behavior be like if rollback fails.

Why is this change necessary: Nucleus restart is unnecessary if preparing bootstrap fails and adds the possibility of a Nucleus Restart Failure when the Nucleus does eventually start up.

How was this change tested:

Any additional information or context required to review the change:

Documentation Checklist:

Compatibility Checklist:

Refer to Compatibility Guidelines for more information.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.