aws-greengrass / aws-greengrass-secret-manager

Greengrass component that manages sensitive data stored with Greengrass. It supports secrets stored in AWS Secrets Manager and provides APIs for components to fetch secrets locally.
Apache License 2.0
7 stars 3 forks source link

refactor: retry other exceptions as well #85

Closed saranyailla closed 5 months ago

saranyailla commented 5 months ago

Issue #, if available:

Description of changes:

More context:

However, in the previous PR changes were made such that, secret manager loads the secrets from local store (which are successfully decrypted), and then update those only when the call to fetch the corresponding latest secret from cloud is successful. I.e if the call fails due to any reason, we ignore it and don't update the local store. We also dont put the secret manager component in ERRORED state.

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 5 months ago

Unit Tests Coverage Report

File Coverage Lines Branches
All files 88% 88% 88% :white_check_mark:

Minimum allowed coverage is 65%

Generated by :monkey: cobertura-action against 01b5301b8365f23e6f83494200e0fb8199cc2821