We were originally setting a min-layer-size of 0 when building a SOCI index for an image. This was mainly due to the constraint put forth by some registries that disallow pushing manifests without any layers. To remain consistent with the CLI, we should use the default min-layer-size (10 MiB). In the case where an empty index is generated, we will log a warning indicating that we are skipping pushing the empty index and exit gracefully.
We should also update the GitHub pages documentation to reflect the possibility that indexes may no longer be generated for smaller images. (Which is the ideal case anyway)
Related Issue
Resolves: #40
Proposed Changes
Please describe the changes proposed in this pull request. This could include bug fixes, feature enhancements, code refactoring, documentation updates, or any other modifications to the codebase.
Reviewers
Please tag the person or team responsible for reviewing this pull request, using the @ symbol followed by their username.
tbulding
commented
1 year ago
We were originally setting a min-layer-size of 0 when building a SOCI index for an image. This was mainly due to the constraint put forth by some registries that disallow pushing manifests without any layers. To remain consistent with the CLI, we should use the default min-layer-size (10 MiB). In the case where an empty index is generated, we will log a warning indicating that we are skipping pushing the empty index and exit gracefully.
We should also update the GitHub pages documentation to reflect the possibility that indexes may no longer be generated for smaller images. (Which is the ideal case anyway)
Related Issue
Resolves: #40
Proposed Changes
Please describe the changes proposed in this pull request. This could include bug fixes, feature enhancements, code refactoring, documentation updates, or any other modifications to the codebase.
Reviewers
Please tag the person or team responsible for reviewing this pull request, using the
@symbol followed by their username.