aws-ia / cfn-ps-ct-newrelic-one

Apache License 2.0
1 stars 1 forks source link

bug: IAM Policies Insufficient when customizing names #12

Open mbeacom opened 11 months ago

mbeacom commented 11 months ago

The current state of the cloudformation templates dictates the end user can't customize the relevant names (as exposed/provided by the input parameters) since the subsequent resources (like IAM policies) are all hardcoded with the default values versus substitutions based on the input parameters.

Example hardcoded value: https://github.com/aws-ia/cfn-ps-ct-newrelic-one/blob/f5c53187596b606e1d9609aaa47516ddfce6aaa1/templates/control-tower-customization.template.yml#L418C7-L418C7

Which is fine if you use the default: https://github.com/aws-ia/cfn-ps-ct-newrelic-one/blob/f5c53187596b606e1d9609aaa47516ddfce6aaa1/templates/control-tower-customization.template.yml#L225, but for some reason this is exposed and customizable to the end user, but not accommodated for.

This issue ultimately leads to the CFN failing to deploy.