Fixed the Python version issue and update the quickstart URLs

rahul188 commented 4 months ago

I created a PR to fix the Python version issue and update the quickstart URLs. This resolves the following issues:

Issue #28 Issue #20 Issue #13

sshvans commented 4 months ago

@rahul188 Instead of updating automation script, pls add the ignore checks in the template.

rahul188 commented 4 months ago

@sshvans i have made changes in templates.

rahul188 commented 3 months ago

@sshvans can you take a look on this? as its customer is waiting for this fix.

sshvans commented 3 months ago

/do-e2e-tests

aws-ia-automator-prod[bot] commented 3 months ago

End to end test has been scheduled

aws-ia-automator-prod[bot] commented 3 months ago

E2E tests in progress

aws-ia-automator-prod[bot] commented 3 months ago

E2E tests in progress

rahul188 commented 3 months ago

@sshvans , can you please elaborate the failure?

sshvans commented 3 months ago

@rahul188 It uses following 3 parameters to deploy the stack. Currently, the test is failing bcz these values are missing in the config file that is stored internally and used while testing the templates. Can you provide these values over email that can be stored and used for testing? NewRelicAccountNumber: '' LaunchAccountList: '' NewRelicAccessKey: ''

rahul188 commented 3 months ago

@sshvans, For testing purposes, to avoid security hiccups please create a new free New Relic account and provide the following values to update the config file:

NewRelicAccountNumber
NewRelicAccessKey

Additionally, could you also provide more information on what values should be populated for the LaunchAccountList variable?

tbulding commented 3 months ago

/do-e2e-tests

aws-ia-automator-prod[bot] commented 3 months ago

End to end test has been scheduled

aws-ia-automator-prod[bot] commented 3 months ago

E2E tests in progress

rahul188 commented 3 months ago

@tbulding , can you give us more insights.

tbulding commented 2 months ago

Please add the additional parameters to your TaskCat test file...

      AdditionalParametersLicenseKey: ''
      NewRelicLicenseKey: ''

Template validation for these templates is failing with errors due to number of characters (32 instead of 40). Additionally the Regex Pattern is reporting false positives when I modified them in my test environment. I changed the pattern from

'^([A-Z0-9-]){32}$'
to 
'^[A-Za-z0-9]{40}$'

templates/control-tower-customization.template.yml templates/newrelic-hub-cfct.yaml

After making these modifications in my test environment, The test started, however it failed when creating the custom resource. Here are the error details...

"
"StackName": "tCaT-cfn-ps-ct-newrelic-one-newrelic-onboarding",
"LogicalResourceId": "NewRelicFirstLaunch",
"PhysicalResourceId": "tCaT-cfn-ps-ct-newrelic-one-newrelic-onboarding-us-west-2-...",
"ResourceType": "AWS::CloudFormation::CustomResource",
"Timestamp": "2024-08-09T17:21:42.851000+00:00",
"ResourceStatus": "CREATE_FAILED",
"ResourceStatusReason": "Received response status [FAILED] from custom resource. Message returned: ERROR: (truncated) xist\nFor more information check ...
(Service: AmazonCloudFormation; Status Code: 400; Error Code: ValidationError; Request ID: ...; Proxy: null) (RequestId: ...)",
"ResourceProperties": "{\"ServiceToken\":\"arn:aws:lambda:us-west-2:...:function:tCaT-cfn-ps-ct-newrelic-o-NewRelicOnboardingFuncti-...\"}"

rahul188 commented 2 months ago

@tbulding the above failure with status code 400 due to StackSetUrl which present in .taskcat.yml file was not accessible. i have updated the same StackSetUrl which is present in control-tower-customization.template.yml file and now its woking as expected.