aws-ia / cfn-ps-red-hat-rhel-with-ha

Apache License 2.0
2 stars 2 forks source link

Rename 'ha_listener' to 'awsvip' #11

Open nlwmn opened 1 year ago

nlwmn commented 1 year ago

The documentation in the HA guide for AWS refers to the resource implemented with 'ha_listener' as 'awsvip'. Renaming the 'ha_listener' resource to 'awsvip' provides parity in terminology.

wombelix commented 1 year ago

I think there are two different things, we use the resource agent ocf:heartbeat:aws-vpc-move-ip and name the resource ha_listener, in the linked guide the used resource agent is ocf::heartbeat:awsvip (AWS Secondary Private IP Address) and name the resource privip.

The resources are described as:

ocf:heartbeat:aws-vpc-move-ip - Move IP within a VPC of the AWS EC2

Resource Agent to move IP addresses within a VPC of the Amazon Webservices EC2 by changing an entry in an specific routing table

ocf:heartbeat:awsvip - Amazon AWS Secondary Private IP Address Resource Agent

Resource Agent for Amazon AWS Secondary Private IP Addresses. It manages AWS Secondary Private IP Addresses with awscli.

My understanding, if your nodes are all in the same AZ and you need a secondary IP in the same subnet that you can move within your cluster, you use ocf:heartbeat:aws-vpc-move-ip.

If your nodes spread across multiple AZs and therefore are in different subnets, you use ocf:heartbeat:aws-vpc-move-ip to reconfigure the routing table of your VPC when the overlay IP moves to let it point to the ENI of the node the resource is running on.

That being said, I'm open to discuss if ha_listener is a good and intuitive name for the cluster virtual ip or if a different name would be more clear about the purpose of this resource.

wombelix commented 12 months ago

@davmayd it doesn't seem that I have the permissions to close an Issue, can you please go ahead and close/resolve this one? There are no further actions based on this Issue, we going to keep the resource name ha_listener for now. Thanks.