search

aws-ia / cfn-ps-red-hat-rhel-with-ha

Apache License 2.0
2 stars 2 forks source link

Refactor: Remove unused package (pystache) and don't upload `get_hostnames.py` in generic node tpl #12

Closed wombelix closed 1 year ago

wombelix commented 1 year ago

pystache removal:

aws-cfn-bootstrap-2.0 only needs pystache if the python version on an EC2 instance is below 3.5. The oldest RHEL version we support with this partner solution is 8.6, which comes by default with Python 3.6.8.

don't upload get_hostnames.py in node.template.yaml:

only the stack lastnode uses the script get_hostnames.py, it doesn't need to be uploaded to the first or one of the extra nodes.

aws-ia-automator-gamma[bot] commented 1 year ago

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch. If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are not ready to publish yet, we recommend you close this PR and develop against a different branch. Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.