Closed wombelix closed 1 year ago
Hi there,
I am commenting because your project has not yet been published and you have opened a pr to the main
branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main
.
If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review process:
/confirm-publication
If you require more information please reach out to your AWS PoC who is assisting you with this project.
let me check why some instance types are marked as invalid in the static analysis and update the PR
Diving deeper into the warnings it looks like that hpc7a
and hpc6a
are not part cfn-lint
yet, c7i
and r7a
were added just 4 days ago (https://github.com/aws-cloudformation/cfn-lint/commit/0daa42cf069dafe14ba46d55a80a5d05731d1ed3), it make sense that the test fails, we don't need them right away, I removed them.
@davmayd I assume that aws-ia-automator-gamma / Static Analysis
uses cfn-lint 0.72.0
? The instances reported in the output of the previous check run indicate it, some of them were added in cfn-lint 0.72.2
. Based on that, I also removed the following instance types / families to satisfy the checks:
- m7i
- m7a
- m6in
- c6in
- r7iz
- r6in
It's not super critical for me right now, but if my assumption is correct: It would be great if cfn-lint
could be updated in the PR checks to a more recent version at some point to reduce false positives :) taskcat 0.9.40
and cfn-lint 0.79.10
for example worked very well together in my local test environment.
I will add further instance types at a later point, I'm good with the extended list we have now, feel free to merge the PR.
Current instance types added to the allowed list, focus on:
Non-current generations removed from allowed list.
Default type changed to 't3.medium'.