aws-ia / cfn-ps-red-hat-rhel-with-ha

Apache License 2.0
2 stars 2 forks source link

Refactor: Remove python helper scripts and HostnameBucket dependency, use native CloudFormation features instead #16

Closed wombelix closed 1 year ago

wombelix commented 1 year ago

Python scripts were used to pass ec2 instance information from first and extra node to lastnode via S3 and trigger cluster configuration on OS level. Deleting the stack caused issues because of files that still exist in the helper bucket.

Refactored to use native CloudFormation features instead.

Cleanup performed, all previously used scripts, parameters and dependencies removed.

Fixes: https://github.com/aws-ia/cfn-ps-red-hat-rhel-with-ha/issues/4

aws-ia-automator-gamma[bot] commented 1 year ago

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch. If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are not ready to publish yet, we recommend you close this PR and develop against a different branch. Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.

wombelix commented 1 year ago

last fixup related to failed deployment in 4 AZs, tests performed - based on new test profiles https://github.com/aws-ia/cfn-ps-red-hat-rhel-with-ha/pull/17 - with RHEL8 and RHEL9 in 2,3 and 4 AZ scenarios without issues.

wombelix commented 1 year ago

Typo in Parameter description corrected, ready to merge.