Closed wombelix closed 11 months ago
Hi there,
I am commenting because your project has not yet been published and you have opened a pr to the main
branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main
.
If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review process:
/confirm-publication
If you require more information please reach out to your AWS PoC who is assisting you with this project.
status: CREATE_COMPLETE ┏ stack Ⓜ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba43916e ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba43916e-VPCStack-1VNQ7VG4K0SHR ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba43-ExtraNode1Stack-G8S8M0RHI2BP ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba439-FirstNodeStack-4TVV9XJWICOQ ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba43916-BastionStack-UV3IE0934LYK ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az3-3726947ef2c749be96f43dd1ba4391-LastNodeStack-XAHBM18GDE4Z ┣ region: us-west-2 ┗ status: CREATE_COMPLETE ┏ stack Ⓜ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba43916e ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba43916e-VPCStack-1WKX63YH48JAU ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba43916e-RHEHAStack-X0O0RZWKQRK4 ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba4391-BastionStack-BA7SY2X130Z9 ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba4-ExtraNode1Stack-148BV7GTN48TT ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba43-FirstNodeStack-1PCRBOYBT8FYL ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc3az-3726947ef2c749be96f43dd1ba439-LastNodeStack-1B7HU1KJCXX2U ┣ region: us-west-2 ┗ status: CREATE_COMPLETE ┏ stack Ⓜ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba43916e ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba43916e-VPCStack-6YJ7HW6WHUTB ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba43916e-RHEHAStack-1VUDJ0F6K2UP6 ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba4391-BastionStack-YX7B7TCFACQM ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba43-FirstNodeStack-1QTJ10UJX0ME ┣ stack Ⓝ tCaT-cfn-ps-red-hat-rhel-with-ha-byovpc2az-3726947ef2c749be96f43dd1ba439-LastNodeStack-1PYZO2CRS37O8 ┣ region: us-east-2 ┗ status: CREATE_COMPLETE ┏ stack Ⓜ tCaT-cfn-ps-red-hat-rhel-with-ha-rhel8az2-3726947ef2c749be96f43dd1ba43916e
Thanks @davmayd and @vsnyc, anything pending or can the PR be merged?
This PR add the necessary functionality that allows customers to use an already existing network setup, Bring Your Own VPC (BYOVPC). This will then also cover deployments on AWS Outposts Servers.
If at least at new Parameters
VPCID
,PublicSubnet1ID
,PublicSubnet2ID
,PrivateSubnet1ARouteTable
,PrivateSubnet2ARouteTable
,PublicSubnetRouteTable
,PrivateSubnet1AID
,PrivateSubnet2AID
are set, the nested stackVPCStack
will be skipped and the provided Parameters used instead.We make the assumption that in case of a selection of
3
or4
AZs the additionalPrivateSubnet
andRoutingTable
ID(s) are also set. There is no additional logic to test it, if a Customer runs the stack without the appropriate and/or correct information, it will fail, which is fine.Three new
taskcat
test profiles were added to cover the feature in the end-to-end tests. To achieve this, a new templatetest.byovpc.yaml
is part of the PR, it contains the bare minimum to deploy theVPCStack
and pass the Outputs as Parameters to theRHELHAStack
(main.template.yaml
). This simulates the behavior as if a Customer would deploy the stack into an already existing VPC.Test deployment with all profiles defined in
.taskcat.yml
successful completed and verified.