search

aws-ia / cloudformation-aws-marketplace-saas

AWS Marketplace Build Tools
Apache License 2.0
25 stars 20 forks source link

SAM deployment fails when `CreateRegistrationWebPage` is set to `false` #49

Closed gargana closed 2 years ago

gargana commented 2 years ago

Upstream project issue causing automation to fail when CreateRegistrationWebPage is set to false https://github.com/aws-samples/aws-marketplace-serverless-saas-integration/issues/53

alanblockley commented 2 years ago

I also ran into this recently and it turns out that the boolean flag is case sensitive.

The workaround is to set it to true or false purposefully.

The long-term plan would require the default to be set appropriately.

gargana commented 2 years ago

I also ran into this recently and it turns out that the boolean flag is case sensitive.

The workaround is to set it to true or false purposefully.

The long-term plan would require the default to be set appropriately.

Thanks for pointing out the case sensitivity thing. I have updated the title and the description. The template does use the AllowedValues property for the parameters so it should complain about invalid parameters if the case is off.

gargana commented 2 years ago

Fix merged and published.