Incorrect, confusing, and typoed field descriptions for SNS topic ARNs

[nathanmcgarvey-modopayments]

Two lines involved:

https://github.com/aws-ia/cloudformation-aws-marketplace-saas/blob/869a30639d134b87ec70ba3ad387be875bd1f9b1/templates/cloudformation-aws-marketplace-saas.template.yaml#L61

https://github.com/aws-ia/cloudformation-aws-marketplace-saas/blob/869a30639d134b87ec70ba3ad387be875bd1f9b1/templates/cloudformation-aws-marketplace-saas.template.yaml#L74

The descriptions of these fields are incorrect (or at least very confusing to the reader) and the one line includes a typo (entitelement).

The likely descriptions should be to just use the correct "entitlement/contract" SNS topic for the Entitlements field and the "subscription" SNS topic for the Subscriptions field. (match the the SNS topic ARN to the parameter field name) If the descriptions are followed, the stack will fail to deploy due to insufficient permissions since a subscription saas marketplace product won't have access to an entitlement notification SNS topic. I'm not sure what the original intent with these descriptions were... perhaps the "Subscriptions SNS topic ARN" was supposed to read "... use the subscriptions SNS topic..."?

[brfrugis]

We are facing the same issue here ..... did you manage to fix it Nathan ?

[nathanmcgarvey-modopayments]

Yeah, the field names seem to be correct and the descriptions seem to be incorrect. So it was working for us if you put the sns topic for "entitlement/contract" in the Entitlements field and ignore the description and put the "subscription" sns topic in the Subscriptions field and ignore that description, too.

[anujguptatecnotree]

Check if, offer is not in Draft/Staging State.

Offer must be in Limited or Public State.