aws-ia / taskcat

Test all the CloudFormation things! (with TaskCat)
https://aws-ia.github.io/taskcat/
Apache License 2.0
1.17k stars 213 forks source link

Add role_arn to delete function in stack.py #807

Closed jtanton closed 1 year ago

jtanton commented 1 year ago

Overview

Update stack.py delete function to use an optional role_arn parameter during delete stack.

Testing/Steps taken to ensure quality

Peer reviewed but needs additional testing to validate.

Notes

Optional. Caveats, Alternatives, Other relevant information.

Testing Instructions

How to test this PR Start after checking out this branch (bulleted) Use role_name in project to create a stack and confirm the delete is also done by the same role.

jtanton commented 1 year ago

Turns out the caller identity performs the delete stack and not the the cloudformation service so this change isn't needed.