aws-ia / taskcat

Test all the CloudFormation things! (with TaskCat)
https://aws-ia.github.io/taskcat/
Apache License 2.0
1.17k stars 213 forks source link

$[taskcat_secretsmanager_] pseudo parameter does not work #817

Open ivallhon opened 9 months ago

ivallhon commented 9 months ago

Describe the bug The $[taskcatsecretsmanager] pseudo parameter does not work. Secrets Manager Parameter Values are not resolved

To Reproduce Steps to reproduce the behavior:

Add the $[taskcat_secretsmanager_mysecret] pseudo parameter to .taskcat.yaml and deploy a CloudFormation template, the resulting CloudFormation parameter value is $[taskcat_secretsmanager_mysecret]

  1. Are you testing a QuickStart or Custom template? - Custom
  2. Attach or link a copy of the template if possible (remove any sensitive info) - template is private, but can be reproduced with any template
  3. Provide the parameters that you passed. (remove any sensitive info) - I tried using both secret id and ARN
  4. How did you install taskcat? (docker or pip3) pip3
  5. Are you using a profile, an instance role or access keys to run taskcat? - profile
  6. Is your AWS environment configured via aws configure? - yes

Expected behavior The taskcat resolves the Secret Value and passes it to CloudFormation

**Version (Please make sure you are running the latest version of taskcat)

Additional context The _get_secretsmanager_param_value_wrapper function is not invoked in the transform_parameter function