aws-ia / terraform-aws-control_tower_account_factory

AWS Control Tower Account Factory
Apache License 2.0
640 stars 440 forks source link

Github Enterprise oauth login #252

Open ganniterix opened 2 years ago

ganniterix commented 2 years ago

We encountered an issue when integrating with Github Enterprise since our organization has a policy to allow access only to logged in users. There is currently no method to supply credentials, example, oauth. It would be great if this scenario could be supported.

v-rosa commented 2 years ago

Could you provide a more explicit example of your goal? When you say access to logged users you mean all your repositories are either private or internal?

ganniterix commented 2 years ago

All our repositories are only published to logged in users. So our definition of "public" is private. Unless we authenticate to Github, there can be no "viewing" the repository.

v-rosa commented 2 years ago

Then check if my gist might help

https://gist.github.com/v-rosa/aa9c8afd44d66c3a81b9920a1bc90e42

Currently I've changed the SSM parameter store to Secret Manager, but the overall concept it's the same.

In my case was to allow the usage of private terraform modules/repositories in AFT pipelines