aws-ia / terraform-aws-control_tower_account_factory

AWS Control Tower Account Factory
Apache License 2.0
605 stars 386 forks source link

Do we can disable VPC endpoints creation? #367

Closed devopscaxsol closed 11 months ago

devopscaxsol commented 1 year ago

Hello Team,

Do we have options to pass arguments and VPC endpoints will not created?

v-rosa commented 1 year ago

Yes, check here:

devopscaxsol commented 1 year ago

Thanks @v-rosa .

I will definitely look into this.

Thanks for info.

devopscaxsol commented 1 year ago

@v-rosa

If we set false in variable.tf , vpc endpoints for all resource will not created RIGHT?

after set false, is there any files need to modify?

v-rosa commented 1 year ago

You need to set false in the module invocation.

I.e.

module "aft" {
  source = "github.com/aws-ia/terraform-aws-control_tower_account_factory"
  .....
  input_aft_vpc_endpoints = false
  ....
devopscaxsol commented 1 year ago

like as below RIGHT?

module "aft" { source = "github.com/aws-ia/terraform-aws-control_tower_account_factory" //Required Vars ct_management_account_id = "" log_archive_account_id = "" audit_account_id = "" aft_management_account_id = "" ct_home_region = "" tf_backend_secondary_region = ""

terraform_version = "1.2.3" input_aft_vpc_endpoints = false

}

Thank You

v-rosa commented 1 year ago

yes, something like that. Give it a try with a terraform plan and check what is changing.

devopscaxsol commented 1 year ago

If we pass as false for vpc endpoint, then how connectivity will occur for few lambda who are in VPC?

Veevaete commented 1 year ago

@devopscaxsol That depends on what you put in your VPC.