search

aws-ia / terraform-aws-control_tower_account_factory

AWS Control Tower Account Factory
Apache License 2.0
604 stars 386 forks source link

aws_eip is using a deprecated vpc configuration #430

Open mikeplem opened 4 months ago

mikeplem commented 4 months ago

Describe the outcome you'd like

As of AFT 1.12.0 the AWS EIP resources are using the deprecated vpc = true configuration.

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

According to the resource documentation the vpc = true needs to change to domain = "vpc"

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

Is your feature request related to a problem you are currently experiencing? If so, please describe.

When running a terraform plan, the following message appears.

╷
│ Warning: Argument is deprecated
│
│   with module.aft_account_request_framework.aws_eip.aft-vpc-natgw-01,
│   on modules/aft-account-request-framework/vpc.tf line 206, in resource "aws_eip" "aft-vpc-natgw-01":
│  206:   vpc   = true
│
│ use domain attribute instead
│
│ (and 3 more similar warnings elsewhere)
╵

Additional context

I am using terraform 1.5.7 with the 5.36.0 version of the AWS provider (terraform-provider-aws_v5.36.0_x5).

Sanjan611 commented 4 months ago

Thanks for bringing this up @mikeplem. This seems like a small fix, we'll add it to our backlog.

dgokcin commented 3 months ago

Describe the outcome you'd like

As of AFT 1.12.0 the AWS EIP resources are using the deprecated vpc = true configuration.

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

According to the resource documentation the vpc = true needs to change to domain = "vpc"

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

Is your feature request related to a problem you are currently experiencing? If so, please describe.

When running a terraform plan, the following message appears.

╷
│ Warning: Argument is deprecated
│
│   with module.aft_account_request_framework.aws_eip.aft-vpc-natgw-01,
│   on modules/aft-account-request-framework/vpc.tf line 206, in resource "aws_eip" "aft-vpc-natgw-01":
│  206:   vpc   = true
│
│ use domain attribute instead
│
│ (and 3 more similar warnings elsewhere)
╵

Additional context

I am using terraform 1.5.7 with the 5.36.0 version of the AWS provider (terraform-provider-aws_v5.36.0_x5).

@mikeplem Did this issue blocked you from updating from 1.11.1 to 1.12.0 or you did not notice a problem and directly started using 1.12.0. Asking because trying to find the root cause of #445

mikeplem commented 3 months ago

Describe the outcome you'd like As of AFT 1.12.0 the AWS EIP resources are using the deprecated vpc = true configuration.

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  vpc   = true
}

According to the resource documentation the vpc = true needs to change to domain = "vpc"

resource "aws_eip" "aft-vpc-natgw-01" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

resource "aws_eip" "aft-vpc-natgw-02" {
  count = var.aft_enable_vpc ? 1 : 0
  domain = "vpc"
}

Is your feature request related to a problem you are currently experiencing? If so, please describe. When running a terraform plan, the following message appears.

╷
│ Warning: Argument is deprecated
│
│   with module.aft_account_request_framework.aws_eip.aft-vpc-natgw-01,
│   on modules/aft-account-request-framework/vpc.tf line 206, in resource "aws_eip" "aft-vpc-natgw-01":
│  206:   vpc   = true
│
│ use domain attribute instead
│
│ (and 3 more similar warnings elsewhere)
╵

Additional context I am using terraform 1.5.7 with the 5.36.0 version of the AWS provider (terraform-provider-aws_v5.36.0_x5).

@mikeplem Did this issue blocked you from updating from 1.11.1 to 1.12.0 or you did not notice a problem and directly started using 1.12.0. Asking because trying to find the root cause of #445

I did not experience any blocking problems. I brought up the ticket up because vpc = true is deprecated and the code should be updated to use the domain = vpc option.