search

aws-ia / terraform-aws-control_tower_account_factory

AWS Control Tower Account Factory
Apache License 2.0
649 stars 454 forks source link

Account provisioning customisations doesn't have api helper scripts #432

Open awsome-user opened 9 months ago

awsome-user commented 9 months ago

Describe the outcome you'd like

There is no way as of now to use private GitHub repositories in the account provisioning customizations phase as there is no shell invocation such as pre-api-helpers.sh for the global customizations.

Is your feature request related to a problem you are currently experiencing? If so, please describe.

The aft workshop describes use cases such as adding custom step functions and lambdas to be called by the aft-account-provisioning-framework step function. Many enterprises define their own modules for lambda functions and other resources which can not be used unfortunately.

Using private github terraform repos at this point would also allow for better testing. A pre-release branch could be used in a sandbox set-up and the main branch in a prod set-up. This allows following git flow to first test features in a separate environment.

hanafya commented 9 months ago

Hey @awsome-user! Thank you for this feature request! I have added this to our backlog for review!

greenflowers commented 1 month ago

That would be indeed very helpful. The root cause is that the buildspec files of the different aft-components are different. In the ct-aft-account-provisioning-customizations.yml the pre/post-api-helpers.sh scripts are not present and not executed.

In contrast the buildspec of aft-global-customizations

I fix should be very straight forward, since the code is already in the other buildspec files.