search

aws-ia / terraform-aws-eks-blueprints-addons

Terraform module which provisions addons on Amazon EKS clusters
https://aws-ia.github.io/terraform-aws-eks-blueprints-addons/main/
Apache License 2.0
272 stars 127 forks source link

How to register external addon updates now that modules have been removed #215

Closed manuelbcd closed 1 year ago

manuelbcd commented 1 year ago

We have updated Sysdig addon with several changes and upgraded some components (i.e. helm chart, etc.)

https://github.com/sysdiglabs/terraform-eksblueprints-sysdig-addon

However we can't update aws-ia/terraform-aws-eks-blueprints module reference since v.4.32.1 got rid of all modules/ subfolders, while 4.32.0 had a reference within modules/ folder https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/80bd3b92e0f82f45a187805d6d847db320a01c31/modules/kubernetes-addons/main.tf#L443

My question is... how we can update referece to our add-on version now that modules/kubernetes-addon/main.tf has been removed?

bryantbiggs commented 1 year ago

Partner addons are now referenced here https://aws-ia.github.io/terraform-aws-eks-blueprints-addons/main/aws-partner-addons/ as opposed to embedding within the addons module. Does this help resolve your question?

manuelbcd commented 1 year ago

Thanks, @bryantbiggs. I assume from your response that partner add-ons versions don't require to be updated any more, is that right? (we had to update the addon version referenced from your respoitory to ours every time we update our addon)

thanks in advance

bryantbiggs commented 1 year ago

that partner add-ons versions don't require to be updated any more, is that right

Correct - we have made changes to resolve the cyclical dependencies and let partners manage their addons as they see fit

manuelbcd commented 1 year ago

Thanks for that. I will try to reference the latest version of aws framework (1.3.0) and confirm that it works (current referenced version 1.2.8 still has references to partner repos)

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

manuelbcd commented 1 year ago

@askulkarni2 @bryantbiggs can we re-open the issue please? it was never resolved, thanks

bryantbiggs commented 1 year ago

Hi @manuelbcd - what is not resolved?

manuelbcd commented 1 year ago

Sorry, I was referring to a different issue. Please ignore.