aws-ia / terraform-aws-eks-blueprints-addons

Terraform module which provisions addons on Amazon EKS clusters
https://aws-ia.github.io/terraform-aws-eks-blueprints-addons/main/
Apache License 2.0
234 stars 109 forks source link

Enable support for aws-fsx-openzfs-csi-driver #352

Open mirajranpura opened 4 months ago

mirajranpura commented 4 months ago

Community Note

What is the outcome that you are trying to reach?

EKS blueprints should natively support the Amazon FSx for OpenZFS CSI Driver

Describe the solution you would like

EKS blueprints should have OpenZFS CSI driver flag just like Amazon FSx for Lustre CSI Driver have enable_aws_fsx_csi_driver = true which installs the CSI drivers for Lustre.

Apparently, one can't bootstrap the EKS cluster with OpenZFS CSI driver.

Describe alternatives you have considered

Manually installing helm chart for Amazon FSx for OpenZFS CSI Driver

joaocc commented 3 months ago

Is this open for inclusion via contributed PR? Or the inclusion is still something that needs to be decided?

askulkarni2 commented 3 months ago

@joaocc yes we are happy to accept a PR! Thanks for working on this!

joaocc commented 3 months ago

Great. I will need some assistance on deciding what would be reasonable defaults and on specifics of xFS. I was trying to decide whether to "emulate" the approach by EFS-CSI, where it uses explicitly defined policies, but I don't know enough about xFS to be able to do anything else than copying the content of the managed policy. On the other hand, to use the recommended approach of the managed policy (as per https://github.com/aws-ia/terraform-aws-eks-blueprints-addon/issues/28) it seems we would have to resort to creating the resource and policy assignment in this project (vs doing it on the addonside of things). Any thoughts welcomed.

joaocc commented 1 month ago

Hi. Draft PR ready for feedback (not yet tested as I wanted to know which of the IAM approaches to follow). Thx