fix: Switch to lazy evaluation for Karpenter node IAM role additional permissions attachment - Githubissues

aws-ia / terraform-aws-eks-blueprints-addons

Terraform module which provisions addons on Amazon EKS clusters

https://aws-ia.github.io/terraform-aws-eks-blueprints-addons/main/

Apache License 2.0

272 stars 127 forks source link

fix: Switch to lazy evaluation for Karpenter node IAM role additional permissions attachment #396

Closed bryantbiggs closed 6 months ago

bryantbiggs commented 6 months ago

What does this PR do?

Change evaluation logic from eager (try()) to lazy (lookup()) to avoid unknown value errors when iterating over computed values https://github.com/clowdhaus/terraform-for-each-unknown

Motivation

Resolves #395

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[x] Yes, I ran pre-commit run -a with this PR

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

raykrueger commented 6 months ago

Confirming that this fixes issue #395 Thanks Bryant!