aws-ia / terraform-aws-eks-blueprints

Configure and deploy complete EKS clusters.
https://aws-ia.github.io/terraform-aws-eks-blueprints/
Apache License 2.0
2.74k stars 1.43k forks source link

Is there any reason why the eks-cluster-with-new-vpc example was removed in v4.25.0? #1709

Closed cer closed 1 year ago

cer commented 1 year ago

IMHO It was a really simple example of a non-fargate cluster. Just wondering?

bryantbiggs commented 1 year ago

the primary reason was that all of our examples provide configurations for creating both a cluster and a VPC so it was redundant.

Is there a particular pattern or solution that you are looking for?

cer commented 1 year ago

I'm putting together some training materials about how to deploy microservices on EKS. eksctl create cluster is the simplest approach. But I'd prefer to use an IaC/Terraform-based setup. I want to point students at a simple, minimal example of a non-Fargate EKS cluster that they can build upon.

bryantbiggs commented 1 year ago

the terraform equivalent would be something like:

module "eks_al2" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 19.15"

  cluster_name    = "example"
  cluster_version = "1.27"

  # EKS Addons
  cluster_addons = {
    coredns    = {}
    kube-proxy = {}
    vpc-cni    = {}
  }

  vpc_id     = module.vpc.vpc_id
  subnet_ids = module.vpc.private_subnets

  eks_managed_node_groups = {
    al2 = {
      instance_types = ["m6i.large"]

      min_size     = 1
      max_size     = 5
      desired_size = 2
    }
  }
}
cer commented 1 year ago

Sure. But sadly, the examples do an excellent job of hiding the potential simplicity. 😀

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

Issue closed due to inactivity.