search

aws-ia / terraform-aws-eks-blueprints

Configure and deploy complete EKS clusters.
https://aws-ia.github.io/terraform-aws-eks-blueprints/
Apache License 2.0
2.68k stars 1.42k forks source link

[QUESTION] aws-node-termination-handler SQS Queue #507

Closed wiseelf closed 2 years ago

wiseelf commented 2 years ago

Please describe your quesiton here

aws-node-termination-handler module creates SQS resource as well as cloudwatch event rules resources, and by default configured to work in Queue mode (it has enableSqsTerminationDraining: true in values.yaml). What is the reason of this? I mean by default after creating it throws a lot of errors: 2022/05/04 16:25:15 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist for this wsdl version.\n\tstatus code: 400, request id: e7866f99-607d-579d-bd47-3575cb56d5fb" event_type=SQS_TERMINATE So basically it doesn't work as expected. Why not to configure queueURL variable in values.yaml?

# queueURL Listens for messages on the specified SQS queue URL
# queueURL: ${queueURL}

Or maybe I'm missing something and there is a way to configure that?

askulkarni2 commented 2 years ago

Hi @wiseelf, thanks for bringing this to our attention. This is a bug. You also raise a valid point about forcing Queue mode instead of letting users opt in. We will get this fixed.

bryantbiggs commented 2 years ago

@askulkarni2 FYI - https://github.com/aws-samples/eks-blueprints-add-ons/issues/32

bryantbiggs commented 2 years ago

I believe this is now resolved with #666