aws-ia / terraform-aws-mwaa

Terraform module for Amazon MWAA(Apache Airflow)
https://registry.terraform.io/modules/aws-ia/mwaa/
Apache License 2.0
41 stars 54 forks source link

bump vpc module to use v5 + Add Terratest scripts #39

Closed maiconrocha closed 6 months ago

maiconrocha commented 1 year ago

What does this PR do?

bump vpc module to use v5 to fix https://github.com/hashicorp/terraform/issues/31730 adding aws_s3_bucket_ownership_controls resource to fix https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/issues/223

Overcome deprecation warnings

Motivation

Errors being faced when running the basic example

More

For Moderators

Additional Notes

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

mwaa_arn = "arn:aws:airflow:eu-west-1:XXXXXXXXX:environment/basic-mwaa"
mwaa_role_arn = "arn:aws:iam::XXXXXXXXX:role/mwaa-executor20230925061623422400000001"
mwaa_security_group_id = "sg-XXXXXXXXX"
mwaa_service_role_arn = "arn:aws:iam::XXXXXXXXX:role/aws-service-role/airflow.amazonaws.com/AWSServiceRoleForAmazonMWAA"
mwaa_status = "AVAILABLE"
mwaa_webserver_url = "XXXXXXXXX.eu-west-1.airflow.amazonaws.com"
maiconrocha commented 1 year ago

I have added Terratest scripts on the last commit to close https://github.com/aws-ia/terraform-aws-mwaa/issues/5

Test Results:

TestExamplesBasic 2023-09-26T09:56:33+09:30 logger.go:66: Destroy complete! Resources: 33 destroyed.
TestExamplesBasic 2023-09-26T09:56:33+09:30 logger.go:66:

Steps to follow: To configure dependencies, run:

cd test go mod init "" go mod tidy Where is the name of your module, typically in the format github.com//.

To run the tests:

cd test go test mwaa_test.go -v -timeout 60m

vara-bonthu commented 6 months ago

@maiconrocha please resolve conflicts so that we can merge the PR

maiconrocha commented 6 months ago

@vara-bonthu done