reference local.vpc instead of aws_vpc for cidr_blocks in data.tf

aws-ia / terraform-aws-vpc

AWS VPC Module

https://registry.terraform.io/modules/aws-ia/vpc/aws/latest

Apache License 2.0

82 stars 89 forks source link

reference local.vpc instead of aws_vpc for cidr_blocks in data.tf #113

Closed findmyname666 closed 1 year ago

findmyname666 commented 1 year ago

Terraform execution is failing in a case VPC shouldn't be created and instead var.vpc_id is provided. The reason is that the code is referencing aws_vpc resource instead of a data-source.

findmyname666 commented 1 year ago

Is there anything I can help with to get PR reviewed & merged pls ?

drewmullen commented 1 year ago

Thanks for opening this issue. This looks right to me

Today is a holiday in us so I'm afk. We should be able to get back to you this week

findmyname666 commented 1 year ago

Thanks @drewmullen for the review. Unfortunately it still cannot be merged :(

drewmullen commented 1 year ago

yes, i left amazon so i dont have access to merge anymore :( its been communicated to the right people and should be merged/ released shortly

thanks again for your patience!