search

aws-ia / terraform-aws-vpc

AWS VPC Module
https://registry.terraform.io/modules/aws-ia/vpc/aws/latest
Apache License 2.0
92 stars 98 forks source link

Allow configure map_public_ip_on_launch #118

Closed javier-geko closed 11 months ago

javier-geko commented 1 year ago

Hello,

I'm using terraform-aws-vpc module and it's fantastic but for compliance standards I need to set attribute map_public_ip_on_launch to false. I don't need dual-stack, just IPv4. Is it possible?

Thanks

drewmullen commented 1 year ago

Hello , thank you foe opening this issue.

I think atm it is not. @pablo19sc can yall add a option here?

https://github.com/aws-ia/terraform-aws-vpc/blob/5c6ad426109cac659d1b81d3b59809a8b411b8ca/main.tf#L65

pablo19sc commented 1 year ago

Hi @javier-geko working on that! Will send a PR in the following days fixing this.

javier-geko commented 1 year ago

thank you!

pablo19sc commented 1 year ago

https://github.com/aws-ia/terraform-aws-vpc/pull/121 - this should fix it :) I'll wait to have it merged before closing this issue.

pablo19sc commented 11 months ago

Fixed in v4.3.2!