search

aws-ia / terraform-aws-vpc

AWS VPC Module
https://registry.terraform.io/modules/aws-ia/vpc/aws/latest
Apache License 2.0
82 stars 89 forks source link

Name tag for Transit Gateway Attachment #120

Closed kjenney closed 8 months ago

kjenney commented 1 year ago

I deployed this module today and I noticed that the Transit Gateway attachments aren't tagged.

The block of code where this is defined is here: https://github.com/aws-ia/terraform-aws-vpc/blob/main/main.tf#L409-L422

Please add the ability to add a Name tag.

drewmullen commented 1 year ago

good catch. thank you for opening this ticket!

pablo19sc commented 1 year ago

https://github.com/aws-ia/terraform-aws-vpc/pull/121 - this should fix it :) I'll wait to have it merged before closing this issue. Thanks for the feedback!

kjenney commented 1 year ago

Thanks so much 👍

trc-smoehn commented 11 months ago

I'm waiting for this as well. Seems like merging from @pablo19sc is blocked?

Usually our network components are all tagged in a specific order. Tried to use the "aws_ec2_tag" resource in order to tag the attachment, but this is always overwritten by the modules "aws_ec2_transit_gateway_vpc_attachment.tgw[0]" resource and can't be ignored on module-level until now.

pablo19sc commented 11 months ago

Hello everyone! sorry for the delay, I was on PTO... let me work today (and maybe Monday) on this to have it fixed ASAP.

kjenney commented 8 months ago

How we doing @pablo19sc? I'm sure this got lost under a pile of other work. Please work on merging this in. Thanks!

pablo19sc commented 8 months ago

Fixed in v4.3.2!

kjenney commented 8 months ago

Thanks!!