aws-ia / terraform-aws-vpc

AWS VPC Module
https://registry.terraform.io/modules/aws-ia/vpc/aws/latest
Apache License 2.0
82 stars 89 forks source link

Enhancement - vpc attribute of aws_eip is depreciated #125

Closed AdamTylerLynch closed 10 months ago

AdamTylerLynch commented 1 year ago

│ Warning: Argument is deprecated │ │ with module.vpc.aws_eip.nat, │ on .terraform/modules/vpc/main.tf line 99, in resource "aws_eip" "nat": │ 99: vpc = true │ │ use domain attribute instead

shihab-uddin-shakil commented 11 months ago

i got same issue

drewmullen commented 11 months ago

Hi thanks for opening this issue. just wanted to clarify - this is only a warning, correct? not an error?

da1ight commented 11 months ago

Just change this line to domain = "vpc"

AdamTylerLynch commented 11 months ago

I have issued a PR to change the declarations.

tibistibi commented 1 month ago

it is still on the main documentation site:

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/latest