provide name override field for flowlog definition

aws-ia / terraform-aws-vpc

AWS VPC Module

https://registry.terraform.io/modules/aws-ia/vpc/aws/latest

Apache License 2.0

82 stars 89 forks source link

provide name override field for flowlog definition #131

Closed drewmullen closed 8 months ago

drewmullen commented 11 months ago

closes: #126

Little bit of a shotgun approach.. could just change the iam role but the resources are logically grouped so i figured this was more clear

$ go test -run  TestExamplesPublicPrivateCWLogs -timeout 45m
...

TestExamplesPublicPrivateCWLogs 2023-08-11T13:40:43-04:00 logger.go:66: 
PASS
ok      github.com/aws-ia/terraform-aws-vpc     235.733s

drewmullen commented 11 months ago

If merged should be 4.4.0

drewmullen commented 11 months ago

A similar topic is being discussed at the provider level as well. some resources have VERY strict restrictions on name_prefixes: https://github.com/hashicorp/terraform-provider-aws/issues/32838

drewmullen commented 9 months ago

@andrew-glenn any chance this can get merged and released?