aws-neuron / neuronx-nemo-megatron

30 stars 11 forks source link

Typo in nemo.collections.nlp.parts.serialization.py #25

Closed evellasques closed 5 months ago

evellasques commented 5 months ago

Hi,

In serialization.py, the save method will use SimpleSaver (when save_xser is true):

class SimpleSaver:

    def __init__(self):
        pass

    def add_save_task(self, data, path):
        torch.save(data, path)

However, in line 105, it tries to instantiate SimplerSaver (instead of SimpleSaver):

  if saver is None:
      saver = SimplerSaver()

This is causing a crash:

    saver = SimplerSaver()
NameError: name 'SimplerSaver' is not defined
evellasques commented 5 months ago

Addressed in PR #26