aws-observability / aws-otel-collector

AWS Distro for OpenTelemetry Collector (see ADOT Roadmap at https://github.com/orgs/aws-observability/projects/4)
https://aws-otel.github.io/
Other
573 stars 239 forks source link

SSM and SecretsManager Config Variable support #1894

Closed driverpt closed 11 months ago

driverpt commented 1 year ago

Is your feature request related to a problem? Please describe. We would like to run OTEL Collector as Lambda Layer but we need the External Provider Key to be injected from AWS SecretsManager. The purpose is to prevent attaching Lambdas to VPC to avoid IP Exhaustion.

Describe the solution you'd like Have a custom AWS Config Provider in OTEL Config, e.g.:

receivers:
    otlp:
      protocols:
        grpc:
        http:
    exporters:
      otlp/external_provider:
        endpoint: "<external_provider_url>"
        headers:
           api-key: ${secretsmanager:${env:SECRET_ARN}}
           compression: gzip
    processors:
    extensions:
    service:
      extensions: [zpages, memory_ballast]
      pipelines:
        traces:
          receivers: [otlp]
          processors: []
          exporters: [otlp/external_provider]

Describe alternatives you've considered N/A

Additional context External Providers as in DataDog, NewRelic, Splunk, etc.....

mhausenblas commented 1 year ago

Thank you, @driverpt and certainly something we can consider for 2023.

driverpt commented 1 year ago

@mhausenblas , is it also possible to add AOT_CONFIG_CONTENT to Lambda?

Lambda doesn't have the ValueFrom thingy.

Ideally we would like to spin out an OTEL Collector the sameway as we do in ECS

adrianpozueco commented 1 year ago

would be really helpful

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

driverpt commented 1 year ago

Not Stale

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

olegstanko commented 1 year ago

I think it's work in progress according to the Roadmap :)

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 11 months ago

This issue was closed because it has been marked as stale for 30 days with no activity.

olegstanko commented 11 months ago

I think it's in progress and can't be closed

vasileh commented 3 months ago

Regarding the secretsmanager scheme on the confmap, are there any plans to bring it live in the AWS Otel collector? I see the topic has been put on closed, but this feature is somehow not available. Thanks for your support.