search

aws-observability / aws-otel-js

AWS Distro for OpenTelemetry JavaScript SDK
https://aws-otel.github.io/
Apache License 2.0
36 stars 22 forks source link

feat: update propagator and ID generator to support opentelemetry-js 0.12.x #36

Closed mickdekkers closed 3 years ago

mickdekkers commented 3 years ago

Updates the propagator to support opentelemetry-js 0.12.x, fixing #35:

Screen Shot 2020-11-27 at 18 01 02

Also bumps the version of the @opentelemetry/core dependency for the ID generator package. That interface did not get any breaking changes.

~I've marked this as a draft for the moment. The unit tests are passing but I haven't looked at the integration tests yet.~

Update: I updated the integration tests and also the ID generator. Everything should support 0.12.x now 😄

anuraaga commented 3 years ago

Thanks a lot for the help, this is looking great! Indeed we'll need to bump the versions in the integration tests too I think.

mickdekkers commented 3 years ago

Happy to help. Thanks for looking at this 😄

I updated the dependencies in the integration tests app but I haven't run it since it doesn't look like the integration tests are intended to be run locally. It looks like the GitHub Actions will deploy the app to AWS so the app can be tested in that environment.