aws-observability / aws-otel-js

AWS Distro for OpenTelemetry JavaScript SDK
https://aws-otel.github.io/
Apache License 2.0
36 stars 22 forks source link

Paths relative to project root for Dockerfile #59

Closed NathanielRN closed 3 years ago

NathanielRN commented 3 years ago

Description

In #58 , I had built the Docker image locally and seen it work fine with these commands, but now I realize that the github-action builds from the root directory. It should be enough to cd sample-apps && npm install && cd ../ first (with the last cd being implicit because the docker image is run from the root) and then do node sample-apps/server.js.

This PR adds that fix.