Performance Threshold breached AFTER Soak Tests completed for the (http, manual) Sample App

[github-actions[bot]]

Description

After the Soak Tests completed, a performance degradation was revealed for commit c72eb9f5d082ec23551cee4bb85ee92b8657f6a8 of the refs/heads/main branch for the (http, manual) Sample App. Check out the Action Logs from the Soak Testing workflow run on GitHub to view the threshold violation.

Useful Links

Snapshots of the Soak Test run are available on the gh-pages branch. These are the snapshots for the violating commit:

The threshold violation should also be noticeable on our graph of Soak Test average results per commit.

[willarmiros]

@NathanielRN is this a regression upstream? Also, any idea why duplicate issues are being created? I thought we made a fix for that but might be misremembering.

[NathanielRN]

@willarmiros Sorry no this isn't an issue upstream, this was my bad for not updating the benchmark output format when I changed the GH action we use in #71. The step to analyze the performance results AFTER was "failing" but not because of performance results. It was because of an invalid format. I fixed that in #75.

Also, any idea why duplicate issues are being created?

Ah yes I'm fairly certain it's because in #71 I only made the change for issues that are posted for performance issues DURING tests, not AFTER. In #76 I added the missing flag to fix this and prevent it from happening again 🙂 .

[NathanielRN]

Closed in #75.

[willarmiros]

Great makes sense, thanks for the patch!