search

aws-observability / aws-otel-js

AWS Distro for OpenTelemetry JavaScript SDK
https://aws-otel.github.io/
Apache License 2.0
36 stars 22 forks source link

Modified sample app http call to use https scheme #81

Closed bhautikpip closed 1 year ago

bhautikpip commented 2 years ago

We should modify sample app's /outgoing-http-call to use https scheme instead of http. Currently, the sample app response throws status code 301 for request like http://aws.amazon.com. We should change this request to something like this (https://aws.amazon.com) which should return 200 response status code. However, I have tested the sample app code locally using https.get('https://aws.amazon.com') but sample app does not instrument https://aws.amazon.com outgoing call. However JS HTTP instrumentation package supports tracing http and https call both. We might need to spend some time to investigate on how can we turn instrumentation for both the scheme and if it's enabled by default for both the schemes then why sample app is not able to instrument https scheme calls. Also, validate that if we have set up server which expects incoming http requests then can we send out going https requests while handling incoming requests?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled

github-actions[bot] commented 1 year ago

This issue was closed because it has been marked as stale for 30 days with no activity.