Closed thpierce closed 3 months ago
Description: We suspect that between this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2787/files - When two Collectors are created with the same name but different namespaces, the ClusterRoleBinding created by the first will be overriden by the second one and this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2938/files - Cleanup ClusterRoles and ClusterRoleBindings created by the operator ... The operator uses finalizer on the collector to run the cleanup, having multiple collectors with the same name is causing test failures like https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/9879456604/job/27295225403
When two Collectors are created with the same name but different namespaces, the ClusterRoleBinding created by the first will be overriden by the second one
Cleanup ClusterRoles and ClusterRoleBindings created by the operator ... The operator uses finalizer on the collector to run the cleanup
In this commit, we are changing the E2E collector tests for fargate/non-fargate (which run concurrently) to use different collector names to ameliorate the test failures.
Note: AOC_NAMESPACE is not used anywhere else:
AOC_NAMESPACE
Link to tracking Issue: N/A
Testing: N/A
Documentation: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description: We suspect that between this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2787/files -
When two Collectors are created with the same name but different namespaces, the ClusterRoleBinding created by the first will be overriden by the second oneand this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2938/files -Cleanup ClusterRoles and ClusterRoleBindings created by the operator ... The operator uses finalizer on the collector to run the cleanup, having multiple collectors with the same name is causing test failures like https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/9879456604/job/27295225403In this commit, we are changing the E2E collector tests for fargate/non-fargate (which run concurrently) to use different collector names to ameliorate the test failures.
Note:
AOC_NAMESPACEis not used anywhere else:Link to tracking Issue: N/A
Testing: N/A
Documentation: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.