Closed williazz closed 1 year ago
I have rebased release/2.0.x
onto this PR so that #412 is no longer included in these changes
In fix: remove redundant trace latency tests, I realized that unit tests to check if trace events capture latency are not needed. Latency fields start_time
and end_time
are required on trace events, so previous unit tests already provide enough coverage.
For http events on the other hand, startTime
and duration
are optional, so we still need to check if latency is captured on error and non-error Http events.
question: In the PR description, you mention that this is merged with #412. Will we still need the other PR or will we close that in favor of having this PR include all changes?
Yeah we'll keep these separate! #412 has been merged into release/2.0.x
. I've rebased those changes onto this PR, so that #417 will only contain the latency changes. Both PRs are now self contained
When we are ready to release 2.0, we will do another PR and merge fast forward 2.0 onto main.
note: I see the commit history is a bit long, please make sure we squash before merging!
💀
Why
As a single page app owner, I rely on AJAX requests to fetch data in the background so that I may present a different view without refreshing. In order to insist on the highest standard, I need observability into the performance of Fetch and Xhr requests, which is best measured by latency.
Changes
trackAllRequests
by defaultDate.now()
timestamps to measure latencystartTime
andduration
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.