search

aws-observability / aws-rum-web

Amazon CloudWatch RUM Web Client
Apache License 2.0
114 stars 65 forks source link

feat: add sessionLimitOverride always record by type #505

Open williazz opened 4 months ago

williazz commented 4 months ago

Purpose

If merged, RUM users can use the below example to bypass sessionEventLimit and record whatever events they need. However, this PR is limited to "always record" configuration and does not support specific limits, which would need us to migrate event counts from cookies to localStorage to avoid pollution. 

const config: AwsRumConfig = {
    ...
    sessionEventLimitOverride: {
        'com.amazonaws.rum.http_event': 0, // always record
        'custom_type': 1 // non-zero limits are not supported in this PR, and will be handled by sessionEventLimit
    }
}

Documentation updates will be addressed in a separate PR.

Depends on

504

Engineering plan for #480 summarized here https://github.com/aws-observability/aws-rum-web/issues/480#issuecomment-1933212088

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.