Neuron observability - Githubissues

aws-observability / cdk-aws-observability-accelerator

CDK AWS Observability Accelerator

https://aws-observability.github.io/cdk-aws-observability-accelerator/

MIT No Attribution

140 stars 36 forks source link

Neuron observability #121

Closed freschri closed 6 months ago

freschri commented 11 months ago

Single New EKS Cluster Open Source Observability Accelerator for Neuron-based clusters depends on https://github.com/aws-observability/aws-observability-accelerator/pull/32 @elamaran11 please check if we want to keep/remove cdk.json from gitignore (we need to be able to add entries that are validated in compilation otherwise github compilation fails on push)

elamaran11 commented 9 months ago

@freschri Any updates to this PR?

freschri commented 9 months ago

@freschri Any updates to this PR?

I addressed all points apart from the addons. One of them depends on another PR in Blueprints (Neuron Device Plugin Addon). My suggestion was on another channel to merge this PR as is, if no other concern, and raise 2 issues to port the addons to Blueprints. That can be done as an exercise by someone with limited experience on Blueprints/Patterns/Observability. Please let me know

elamaran11 commented 9 months ago

@freschri Any updates to this PR?

I addressed all points apart from the addons. One of them depends on another PR in Blueprints (Neuron Device Plugin Addon). My suggestion was on another channel to merge this PR as is, if no other concern, and raise 2 issues to port the addons to Blueprints. That can be done as an exercise by someone with limited experience on Blueprints/Patterns/Observability. Please let me know

Thats a good opportunity mentor, if you have some one in your region. If i have someone, i will let you know. But this is not a burning one, please take it slow.