search

aws-observability / cdk-aws-observability-accelerator

CDK AWS Observability Accelerator
https://aws-observability.github.io/cdk-aws-observability-accelerator/
MIT No Attribution
138 stars 34 forks source link

Control Plane Logging as a default in all patterns #129

Closed 5herlocked closed 6 months ago

5herlocked commented 7 months ago

Issue #, if available: #118

Description of changes: Added control plane logging through upstream changes and minor modifications to blueprints. Included documentation changes + instructions on how to access Control Plane logs in CloudWatch. Control Plane logging is an in-place change to EKS clusters and should not be a breaking change.

Hard dependency on https://github.com/aws-quickstart/cdk-eks-blueprints/commit/d8262234ffcb66d748e1fd2d2273a5208cbbff67 being packaged and released.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

5herlocked commented 6 months ago

Resolved the comments in the docs, ready to GTM after deployment of the upstream changes.

elamaran11 commented 6 months ago

@5herlocked GH Failure needs to be fixed.

5herlocked commented 6 months ago

Error has nothing to do with my code.

elamaran11 commented 6 months ago

Error has nothing to do with my code.

This is not because of your code but did you pull from main, that could be the reason. I had one PR yesterday and we never had that error.

elamaran11 commented 6 months ago

/do-e2e-test single-new-eks-awsnative-observability deploy

elamaran11 commented 6 months ago

/do-e2e-test single-new-eks-awsnative-observability destroy