aws-observability / cdk-aws-observability-accelerator

CDK AWS Observability Accelerator
https://aws-observability.github.io/cdk-aws-observability-accelerator/
MIT No Attribution
138 stars 34 forks source link

Ship Constructs compatible with vanilla aws-cdk-lib/aws-eks #161

Closed sam-goodwin closed 1 month ago

sam-goodwin commented 1 month ago

Is it possible to use these configurations as Construct libraries? I find the workflow of cloning this repo and running make to be at odds with how the rest of the AWS CDK ecosystem works. I have an existing EKS cluster deployed with the AWS CDK. I would expect a simple Construct I can instantiate and pass a reference to my aws-eks.Cluster, but this library seems to require I am using eks-blueprints (which has the same problem of diverging from standard AWS CDK practices).

new ObservabilityAccelerator(this, "Observability", {
  cluster: myCluster,
  // customize with props
});
elamaran11 commented 1 month ago

EKS Blueprints and CDK Accelerator for EKS are opinionated and purpose built solutions for setting up EKS clusters with Day 2 ops toolings. [ObservabilityBuilder](https://github.com/aws-quickstart/cdk-eks-blueprints/blob/main/lib/builders/observability-builder.ts) is not a construct library but an extension of BlueprintsBuilder. @shapirov103 Anything to add here?

shapirov103 commented 1 month ago

Sam and I already discussed it on the blueprints side. I view the request as valid, e.g. reusing existing stacks with some components of the blueprints. I believe outside of the stylistic preferences and opinions on what is idiomatic in node/TS, the main obstacle was that the EKSBlueprint produced a stack rather than a construct. we don't have anything on the roadmap atm, but if there was a confirmed customer demand, we can make it happen.

elamaran11 commented 1 month ago

I understand your disappointment but We wont support the requested feature anytime in future. We will keep you posted with this issue if things change.