aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
9 stars 17 forks source link

Annotation are not being attached the service account #113

Open Blunderchips opened 1 month ago

Blunderchips commented 1 month ago

Looking at this value here to pass annotations down to the service accounts, it does not seem to be used anywhere in the chart?

For what I can see it is just not used anywhere. Expecting to see it being passed somewhere here:

apiVersion: v1
kind: ServiceAccount
metadata:
  labels:
    {{- include "amazon-cloudwatch-observability.labels" . | nindent 4}}
  name: {{ template "amazon-cloudwatch-observability.managerServiceAccountName" . }}
  namespace: {{ .Release.Namespace }}

What I am trying to is to attach eks.amazonaws.com/role-arn for the manager to use. But I am ending up with the following:

Name:                amazon-cloudwatch-observability-controller-manager
Namespace:           amazon-cloudwatch
Labels:              app.kubernetes.io/instance=amazon-cloudwatch-observability
                     app.kubernetes.io/managed-by=Helm
                     app.kubernetes.io/name=amazon-cloudwatch-observability
                     app.kubernetes.io/version=1.0.0
Annotations:         meta.helm.sh/release-name: amazon-cloudwatch-observability
                     meta.helm.sh/release-namespace: amazon-cloudwatch
Image pull secrets:  <none>
Mountable secrets:   <none>
Tokens:              <none>
Events:              <none>
kikuoemoto commented 1 month ago

@Blunderchips I believe the PR #78 addresses this issue.

Blunderchips commented 1 month ago

@Blunderchips I believe the PR #78 addresses this issue.

Yes looks like it.