aws-observability / helm-charts

The AWS Observability Helm Charts repository contains Helm charts to provide easy mechanisms to setup the CloudWatch Agent and other collection agents to collect telemetry data such as metrics, logs and traces to send to AWS monitoring services.
Apache License 2.0
9 stars 17 forks source link

Allow daemonsets resources customization #62

Closed m00lecule closed 4 months ago

m00lecule commented 4 months ago

Hi,

Currently all aws-cloudwatch-observability daemonsets resources are hardcoded, which is considered a bad practice. Those parameters should be moved to values.yaml file to allow user customization depending what actual utilization they are facing.

cloudwatch-agent: https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L47 dcgm-exporter: https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/dcgm-exporter-daemonset.yaml#L26 fluent-bit: https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/fluent-bit-daemonset.yaml#L50 neuron: https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/neuron-monitor-daemonset.yaml#L28